Commit 599f7965 authored May 18, 2015 by Mayank Rana Committed by Matt Wagantall May 30, 2015

dwc3: gadget: Initialized USB TRBs pool memory with zero



dma_coherent_alloc() API doesn't guaranteed that allocated memory
is initialized with zero. It is observed in some cases where there
is stale data seen with allocated memory for TRB pool and providing
this TRB with USB controller results into different memory access
issues. Fix this issue by using dma_zalloc_coherent() API which
allocates memory and initialized it with zero.

Change-Id: I160e319aace262958a11ba5196f53ec21b98977f
Signed-off-by: Mayank Rana <mrana@codeaurora.org>

parent dca5828c

drivers/usb/dwc3/gadget.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -411,7 +411,7 @@ static int dwc3_alloc_trb_pool(struct dwc3_ep *dep)
		if (dep->number == 0 \|\| dep->number == 1)
		return 0;

		dep->trb_pool = dma_alloc_coherent(dwc->dev,
		dep->trb_pool = dma_zalloc_coherent(dwc->dev,
		sizeof(struct dwc3_trb) * DWC3_TRB_NUM,
		&dep->trb_pool_dma, GFP_KERNEL);
		if (!dep->trb_pool) {