Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 593261ce authored by Jann Horn's avatar Jann Horn Committed by Pavankumar Kondeti
Browse files

sched: panic on corrupted stack end 



Until now, hitting this BUG_ON caused a recursive oops (because oops
handling involves do_exit(), which calls into the scheduler, which in
turn raises an oops), which caused stuff below the stack to be
overwritten until a panic happened (e.g.  via an oops in interrupt
context, caused by the overwritten CPU index in the thread_info).

Just panic directly.

Change-Id: Id8d9bee96902bfefdc1d0d34cf98f3fd88f370f2
Signed-off-by: default avatarJann Horn <jannh@google.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarDennis Cagle <d-cagle@codeaurora.org>
Git-repo: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git


Git-commit: 29d6455178a09e1dc340380c582b13356227e8df
[pkondeti@codeaurora.org: applied the fix for QHMP scheduler files]
Signed-off-by: default avatarPavankumar Kondeti <pkondeti@codeaurora.org>
parent d3e41c96

kernel/sched/qhmp_core.c

+2 −1
Original line number Diff line number Diff line
@@ -4526,7 +4526,8 @@ static noinline void __schedule_bug(struct task_struct *prev) 
static inline void schedule_debug(struct task_struct *prev)

{

#ifdef CONFIG_SCHED_STACK_END_CHECK

	BUG_ON(unlikely(task_stack_end_corrupted(prev)));

	if (unlikely(task_stack_end_corrupted(prev)))

		panic("corrupted stack end detected inside scheduler\n");

#endif

	/*

	 * Test if we are atomic. Since do_exit() needs to call into