Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 58bc8b7e authored by Johannes Schellen's avatar Johannes Schellen Committed by Mauro Carvalho Chehab
Browse files

[media] omap3isp: Fix histogram regions 



This patch fixes a bug which causes all histogram regions to start in the
top left corner of the image. The histogram region coordinates are 16 bit
values which share a 32 bit register. The bug is due to the region end
value assignments overwriting the region start values with zero.

Signed-off-by: default avatarJohannes Schellen <Johannes.Schellen@rwth-aachen.de>
Signed-off-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent cf2b4cf6

drivers/media/platform/omap3isp/isphist.c

+8 −8
Original line number Diff line number Diff line
@@ -114,14 +114,14 @@ static void hist_setup_regs(struct ispstat *hist, void *priv) 
	/* Regions size and position */

	for (c = 0; c < OMAP3ISP_HIST_MAX_REGIONS; c++) {

		if (c < conf->num_regions) {

			reg_hor[c] = conf->region[c].h_start <<

				     ISPHIST_REG_START_SHIFT;

			reg_hor[c] = conf->region[c].h_end <<

				     ISPHIST_REG_END_SHIFT;

			reg_ver[c] = conf->region[c].v_start <<

				     ISPHIST_REG_START_SHIFT;

			reg_ver[c] = conf->region[c].v_end <<

				     ISPHIST_REG_END_SHIFT;

			reg_hor[c] = (conf->region[c].h_start <<

				     ISPHIST_REG_START_SHIFT)

				   | (conf->region[c].h_end <<

				     ISPHIST_REG_END_SHIFT);

			reg_ver[c] = (conf->region[c].v_start <<

				     ISPHIST_REG_START_SHIFT)

				   | (conf->region[c].v_end <<

				     ISPHIST_REG_END_SHIFT);

		} else {

			reg_hor[c] = 0;

			reg_ver[c] = 0;