Commit 57f13be5 authored Apr 28, 2015 by Mayank Rana Committed by Matt Wagantall May 30, 2015

dwc3: gadget: Add NULL check against endpoint's desc in set_halt()



In few instances, dwc3_gadget_ep_set_halt() API is called after USB
endpoint is disabled which results into device crash with NULL pointer
dereference. USB endpoint's descriptors are set to NULL as part of USB
endpoint disable functionality. Hence fix this issue by adding NULL
pointer check against endpoint's descriptor.

CRs-Fixed: 829034
Change-Id: I2e1f67571ed202fab21655bd8f13fc54706419a7
Signed-off-by: Mayank Rana <mrana@codeaurora.org>

parent fce06143

drivers/usb/dwc3/gadget.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -1547,6 +1547,11 @@ static int dwc3_gadget_ep_set_halt(struct usb_ep *ep, int value)

		int ret;

		if (!ep->desc) {
		dev_err(dwc->dev, "(%s)'s desc is NULL.\n", dep->name);
		return -EINVAL;
		}

		spin_lock_irqsave(&dwc->lock, flags);
		dbg_event(dep->number, "HALT", value);
		ret = __dwc3_gadget_ep_set_halt(dep, value, false);