Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 57a57499 authored by Roel Kluin's avatar Roel Kluin Committed by David S. Miller
Browse files

phylib: unsigneds go unnoticed 



both pdata->mdc and pdata->mdio are unsigned. Notice a negative
return value.

Signed-off-by: default avatarRoel Kluin <roel.kluin@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9f4d26d0

drivers/net/phy/mdio-gpio.c

+9 −4
Original line number Diff line number Diff line
@@ -200,16 +200,21 @@ static int __devinit mdio_ofgpio_probe(struct of_device *ofdev, 
{

	struct device_node *np = NULL;

	struct mdio_gpio_platform_data *pdata;

	int ret;



	pdata = kzalloc(sizeof(*pdata), GFP_KERNEL);

	if (!pdata)

		return -ENOMEM;



	pdata->mdc = of_get_gpio(ofdev->node, 0);

	pdata->mdio = of_get_gpio(ofdev->node, 1);

	ret = of_get_gpio(ofdev->node, 0);

	if (ret < 0)

		goto out_free;

	pdata->mdc = ret;



	if (pdata->mdc < 0 || pdata->mdio < 0)

	ret = of_get_gpio(ofdev->node, 1);

	if (ret < 0)

                goto out_free;

	pdata->mdio = ret;



	while ((np = of_get_next_child(ofdev->node, np)))

		if (!strcmp(np->type, "ethernet-phy"))