Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 57401d5e authored Apr 11, 2009 by Dan Carpenter Committed by David S. Miller Apr 11, 2009

phy: error handling for platform_device_register_simple()

platform_device_register_simple() returns ERR_PTR() and not NULL.

Found by smatch (http://repo.or.cz/w/smatch.git

).  Compile tested.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 3384901f

drivers/net/phy/fixed.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -19,6 +19,7 @@
		#include <linux/mii.h>
		#include <linux/phy.h>
		#include <linux/phy_fixed.h>
		#include <linux/err.h>

		#define MII_REGS_NUM 29

		@@ -207,8 +208,8 @@ static int __init fixed_mdio_bus_init(void)
		int ret;

		pdev = platform_device_register_simple("Fixed MDIO bus", 0, NULL, 0);
		if (!pdev) {
		ret = -ENOMEM;
		if (IS_ERR(pdev)) {
		ret = PTR_ERR(pdev);
		goto err_pdev;
		}