Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 56e34ee2 authored by Roland Dreier's avatar Roland Dreier Committed by Nicholas Bellinger
Browse files

target: Make se_dev_check_online() locking IRQ-safe 



se_dev_check_online() is called from transport_lookup_cmd_lun(), which
as discussed before may be called from interrupt context.  So it needs
to use spin_lock_irqsave() instead of spin_lock_irq() to avoid
enabling interrupts at the wrong time.

Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 78faae37

drivers/target/target_core_device.c

+3 −2
Original line number Diff line number Diff line
@@ -813,12 +813,13 @@ static void se_dev_stop(struct se_device *dev) 


int se_dev_check_online(struct se_device *dev)

{

	unsigned long flags;

	int ret;



	spin_lock_irq(&dev->dev_status_lock);

	spin_lock_irqsave(&dev->dev_status_lock, flags);

	ret = ((dev->dev_status & TRANSPORT_DEVICE_ACTIVATED) ||

	       (dev->dev_status & TRANSPORT_DEVICE_DEACTIVATED)) ? 0 : 1;

	spin_unlock_irq(&dev->dev_status_lock);

	spin_unlock_irqrestore(&dev->dev_status_lock, flags);



	return ret;

}