Commit 56335936 authored Jan 06, 2010 by OGAWA Hirofumi Committed by Trond Myklebust Jan 06, 2010

nfs: fix oops in nfs_rename()



Recent change is missing to update "rehash".  With that change, it will
become the cause of adding dentry to hash twice.

This explains the reason of Oops (dereference the freed dentry in
__d_lookup()) on my machine.

Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Reported-by: Marvin <marvin24@gmx.de>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

parent 6c853099

fs/nfs/dir.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1615,6 +1615,7 @@ static int nfs_rename(struct inode old_dir, struct dentry old_dentry,
		goto out;

		new_dentry = dentry;
		rehash = NULL;
		new_inode = NULL;
		}
		}