Commit 557a701c authored Dec 14, 2009 by Thomas Renninger Committed by Dave Jones Jan 13, 2010

[CPUFREQ] Fix use after free of struct powernow_k8_data

Easy fix for a regression introduced in 2.6.31.

On managed CPUs the cpufreq.c core will call driver->exit(cpu) on the
managed cpus and powernow_k8 will free the core's data.

Later driver->get(cpu) function might get called trying to read out the
current freq of a managed cpu and the NULL pointer check does not work on
the freed object -> better set it to NULL.

->get() is unsigned and must return 0 as invalid frequency.

Reference:
http://bugzilla.kernel.org/show_bug.cgi?id=14391



Signed-off-by: Thomas Renninger <trenn@suse.de>
Tested-by: Michal Schmidt <mschmidt@redhat.com>
CC: stable@kernel.org
Signed-off-by: Dave Jones <davej@redhat.com>

parent 292e0041

arch/x86/kernel/cpu/cpufreq/powernow-k8.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1356,6 +1356,7 @@ static int __devexit powernowk8_cpu_exit(struct cpufreq_policy *pol)

		kfree(data->powernow_table);
		kfree(data);
		per_cpu(powernow_data, pol->cpu) = NULL;

		return 0;
		}
		@@ -1375,7 +1376,7 @@ static unsigned int powernowk8_get(unsigned int cpu)
		int err;

		if (!data)
		return -EINVAL;
		return 0;

		smp_call_function_single(cpu, query_values_on_cpu, &err, true);
		if (err)