Commit 54f5968d authored Jan 30, 2014 by Levente Kurusa Committed by Linus Torvalds Jan 30, 2014

drivers/video/backlight/lcd.c: call put_device if device_register fails



Currently we kfree the container of the device which failed to register.
This is wrong as the last reference is not given up with a put_device
call.  Also, now that we have put_device() callen, we no longer need the
kfree as the new_ld->dev.release function will take care of kfreeing the
associated memory.

Signed-off-by: Levente Kurusa <levex@linux.com>
Acked-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 07bacb38

drivers/video/backlight/lcd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -228,7 +228,7 @@ struct lcd_device lcd_device_register(const char name, struct device *parent,

		rc = device_register(&new_ld->dev);
		if (rc) {
		kfree(new_ld);
		put_device(&new_ld->dev);
		return ERR_PTR(rc);
		}