Commit 54b85f48 authored Mar 19, 2006 by Adrian Bunk Committed by John W. Linville Mar 23, 2006

[PATCH] hostap: Fix ap_add_sta() return value verification



The Coverity checker (CID: 273) spotted this inconsequent NULL checking
(unconditionally dereferencing directly after checking for NULL
isn't a good idea). Return immediately to avoid this.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Jouni Malinen <jkmaline@cc.hut.fi>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 971d1e69

drivers/net/wireless/hostap/hostap_ap.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3141,7 +3141,7 @@ int hostap_add_sta(struct ap_data ap, u8 sta_addr)
		if (ret == 1) {
		sta = ap_add_sta(ap, sta_addr);
		if (!sta)
		ret = -1;
		return -1;
		sta->flags = WLAN_STA_AUTH \| WLAN_STA_ASSOC;
		sta->ap = 1;
		memset(sta->supported_rates, 0, sizeof(sta->supported_rates));