Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5462eddd authored by Somnath Kotur's avatar Somnath Kotur Committed by Roland Dreier
Browse files

RDMA/cma: Handle global/non-linklocal IPv6 addresses in cma_check_linklocal()



If addr is not a linklocal address, the code incorrectly fails to
return and ends up assigning the scope ID to the scope id of the
address, which is wrong.  Fix by checking if it's a link local address
first, and immediately return 0 if not.

Signed-off-by: default avatarSomnath Kotur <somnath.kotur@emulex.com>
Signed-off-by: default avatarRoland Dreier <roland@purestorage.com>
parent 7e22e911
Loading
Loading
Loading
Loading
+5 −2
Original line number Diff line number Diff line
@@ -2480,8 +2480,11 @@ static int cma_check_linklocal(struct rdma_dev_addr *dev_addr,
		return 0;

	sin6 = (struct sockaddr_in6 *) addr;
	if ((ipv6_addr_type(&sin6->sin6_addr) & IPV6_ADDR_LINKLOCAL) &&
	    !sin6->sin6_scope_id)

	if (!(ipv6_addr_type(&sin6->sin6_addr) & IPV6_ADDR_LINKLOCAL))
		return 0;

	if (!sin6->sin6_scope_id)
			return -EINVAL;

	dev_addr->bound_dev_if = sin6->sin6_scope_id;