Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5448d75f authored by Bjørn Mork's avatar Bjørn Mork Committed by David S. Miller
Browse files

net: cdc_ncm: log signatures in hex 



These signatures are well known bit patterns, mostly made up
of ascii characters.  Mentally parsing works best if they
are printed in hex.

Cc: Alexey Orishko <alexey.orishko@gmail.com>
Signed-off-by: default avatarBjørn Mork <bjorn@mork.no>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ae223cd4

drivers/net/usb/cdc_ncm.c

+6 −4
Original line number Diff line number Diff line
@@ -883,7 +883,8 @@ int cdc_ncm_rx_verify_nth16(struct cdc_ncm_ctx *ctx, struct sk_buff *skb_in) 
	nth16 = (struct usb_cdc_ncm_nth16 *)skb_in->data;



	if (le32_to_cpu(nth16->dwSignature) != USB_CDC_NCM_NTH16_SIGN) {

		pr_debug("invalid NTH16 signature <%u>\n",

		netif_dbg(dev, rx_err, dev->net,

			  "invalid NTH16 signature <%#010x>\n",

			  le32_to_cpu(nth16->dwSignature));

		goto error;

	}
@@ -972,7 +973,8 @@ next_ndp: 
	ndp16 = (struct usb_cdc_ncm_ndp16 *)(skb_in->data + ndpoffset);



	if (le32_to_cpu(ndp16->dwSignature) != USB_CDC_NCM_NDP16_NOCRC_SIGN) {

		pr_debug("invalid DPT16 signature <%u>\n",

		netif_dbg(dev, rx_err, dev->net,

			  "invalid DPT16 signature <%#010x>\n",

			  le32_to_cpu(ndp16->dwSignature));

		goto err_ndp;

	}