Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5434b203 authored by Bartlomiej Zolnierkiewicz's avatar Bartlomiej Zolnierkiewicz Committed by Tejun Heo
Browse files

ata: ahci_platform: fix devm_ioremap_resource() return value checking 



devm_ioremap_resource() returns a pointer to the remapped memory or
an ERR_PTR() encoded error code on failure.  Fix the check inside
ahci_platform_get_resources() accordingly.

Also while at it remove a needless line break.

Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 13e8e78b

drivers/ata/ahci_platform.c

+3 −3
Original line number Diff line number Diff line
@@ -199,8 +199,7 @@ static void ahci_platform_put_resources(struct device *dev, void *res) 
 * RETURNS:

 * The allocated ahci_host_priv on success, otherwise an ERR_PTR value

 */

struct ahci_host_priv *ahci_platform_get_resources(

	struct platform_device *pdev)

struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev)

{

	struct device *dev = &pdev->dev;

	struct ahci_host_priv *hpriv;
@@ -219,8 +218,9 @@ struct ahci_host_priv *ahci_platform_get_resources( 


	hpriv->mmio = devm_ioremap_resource(dev,

			      platform_get_resource(pdev, IORESOURCE_MEM, 0));

	if (!hpriv->mmio) {

	if (IS_ERR(hpriv->mmio)) {

		dev_err(dev, "no mmio space\n");

		rc = PTR_ERR(hpriv->mmio);

		goto err_out;

	}