Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 540eac0e authored by Jerome Brunet's avatar Jerome Brunet Committed by Greg Kroah-Hartman
Browse files

net: stmmac: enable EEE in MII, GMII or RGMII only 




[ Upstream commit 879626e3a52630316d817cbda7cec9a5446d1d82 ]

Note in the databook - Section 4.4 - EEE :
" The EEE feature is not supported when the MAC is configured to use the
TBI, RTBI, SMII, RMII or SGMII single PHY interface. Even if the MAC
supports multiple PHY interfaces, you should activate the EEE mode only
when the MAC is operating with GMII, MII, or RGMII interface."

Applying this restriction solves a stability issue observed on Amlogic
gxl platforms operating with RMII interface and the internal PHY.

Fixes: 83bf79b6 ("stmmac: disable at run-time the EEE if not supported")
Signed-off-by: default avatarJerome Brunet <jbrunet@baylibre.com>
Tested-by: default avatarArnaud Patard <arnaud.patard@rtp-net.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7247c48a

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

+6 −0
Original line number Diff line number Diff line
@@ -277,8 +277,14 @@ bool stmmac_eee_init(struct stmmac_priv *priv) 
{

	char *phy_bus_name = priv->plat->phy_bus_name;

	unsigned long flags;

	int interface = priv->plat->interface;

	bool ret = false;



	if ((interface != PHY_INTERFACE_MODE_MII) &&

	    (interface != PHY_INTERFACE_MODE_GMII) &&

	    !phy_interface_mode_is_rgmii(interface))

		goto out;



	/* Using PCS we cannot dial with the phy registers at this stage

	 * so we do not support extra feature like EEE.

	 */

include/linux/phy.h

+11 −0
Original line number Diff line number Diff line
@@ -677,6 +677,17 @@ static inline int phy_write_mmd(struct phy_device *phydev, int devad, 
	return mdiobus_write(phydev->bus, phydev->addr, regnum, val);

}



/**

 * phy_interface_mode_is_rgmii - Convenience function for testing if a

 * PHY interface mode is RGMII (all variants)

 * @mode: the phy_interface_t enum

 */

static inline bool phy_interface_mode_is_rgmii(phy_interface_t mode)

{

	return mode >= PHY_INTERFACE_MODE_RGMII &&

		mode <= PHY_INTERFACE_MODE_RGMII_TXID;

};



/**

 * phy_write_mmd_indirect - writes data to the MMD registers

 * @phydev: The PHY device