Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 533cec8f authored by Bill Richardson's avatar Bill Richardson Committed by Lee Jones
Browse files

mfd: cros_ec: cleanup: remove unused fields from struct cros_ec_device 



struct cros_ec_device has a superfluous "name" field. We can get all the
debugging info we need from the existing ec_name and phys_name fields, so
let's take out the extra field.

The printout also has sufficient info in it without explicitly adding
the transport.  Before this change:
  cros-ec-spi spi2.0: Chrome EC (SPI)

After this change:
  cros-ec-spi spi2.0: Chrome EC device registered

Signed-off-by: default avatarBill Richardson <wfrichar@chromium.org>
Signed-off-by: default avatarDoug Anderson <dianders@chromium.org>
Reviewed-by: default avatarSimon Glass <sjg@chromium.org>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 5d4773e2

drivers/mfd/cros_ec.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -140,7 +140,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev) 
		goto fail_mfd;

		goto fail_mfd;

	}

	}





	dev_info(dev, "Chrome EC (%s)\n", ec_dev->name);

	dev_info(dev, "Chrome EC device registered\n");





	return 0;

	return 0;

drivers/mfd/cros_ec_i2c.c

+0 −1
Original line number Original line Diff line number Diff line
@@ -132,7 +132,6 @@ static int cros_ec_i2c_probe(struct i2c_client *client, 
		return -ENOMEM;

		return -ENOMEM;





	i2c_set_clientdata(client, ec_dev);

	i2c_set_clientdata(client, ec_dev);

	ec_dev->name = "I2C";

	ec_dev->dev = dev;

	ec_dev->dev = dev;

	ec_dev->priv = client;

	ec_dev->priv = client;

	ec_dev->irq = client->irq;

	ec_dev->irq = client->irq;

drivers/mfd/cros_ec_spi.c

+0 −1
Original line number Original line Diff line number Diff line
@@ -370,7 +370,6 @@ static int cros_ec_spi_probe(struct spi_device *spi) 
	cros_ec_spi_dt_probe(ec_spi, dev);

	cros_ec_spi_dt_probe(ec_spi, dev);





	spi_set_drvdata(spi, ec_dev);

	spi_set_drvdata(spi, ec_dev);

	ec_dev->name = "SPI";

	ec_dev->dev = dev;

	ec_dev->dev = dev;

	ec_dev->priv = ec_spi;

	ec_dev->priv = ec_spi;

	ec_dev->irq = spi->irq;

	ec_dev->irq = spi->irq;

include/linux/mfd/cros_ec.h

+0 −2
Original line number Original line Diff line number Diff line
@@ -67,7 +67,6 @@ struct cros_ec_command { 
 * @command_recv: receive a response

 * @command_recv: receive a response

 * @command_sendrecv: send a command and receive a response

 * @command_sendrecv: send a command and receive a response

 *

 *

 * @name: Name of this EC interface

 * @priv: Private data

 * @priv: Private data

 * @irq: Interrupt to use

 * @irq: Interrupt to use

 * @din: input buffer (for data from EC)

 * @din: input buffer (for data from EC)
@@ -104,7 +103,6 @@ struct cros_ec_device { 
				void *in_buf, int in_len);

				void *in_buf, int in_len);





	/* These are used to implement the platform-specific interface */

	/* These are used to implement the platform-specific interface */

	const char *name;

	void *priv;

	void *priv;

	int irq;

	int irq;

	uint8_t *din;

	uint8_t *din;