Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 530a5a50 authored by Balaji T K's avatar Balaji T K Committed by Tony Lindgren
Browse files

OMAP4: Fix -EINVAL for vana, vcxio, vdac 



Fixed regulators in twl6030 do not have set_voltage hook.
Regulator core returns -22 if set_voltage is NULL and apply_uV is set
while applying the constraint to set voltage resulting in failure during probe
of these regulators.
Do not set apply_uV for fixed regulators which don't have set_voltage.

machine_constraints_voltage: VANA: failed to apply 2100000uV constraint
twl_reg twl_reg.43: can't register VANA, -22
twl_reg: probe of twl_reg.43 failed with error -22
machine_constraints_voltage: VCXIO: failed to apply 1800000uV constraint
twl_reg twl_reg.44: can't register VCXIO, -22
twl_reg: probe of twl_reg.44 failed with error -22
machine_constraints_voltage: VDAC: failed to apply 1800000uV constraint
twl_reg twl_reg.45: can't register VDAC, -22
twl_reg: probe of twl_reg.45 failed with error -22

Signed-off-by: default avatarBalaji T K <balajitk@ti.com>
Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
parent 73a92aa4

arch/arm/mach-omap2/board-4430sdp.c

+0 −3
Original line number Diff line number Diff line
@@ -433,7 +433,6 @@ static struct regulator_init_data sdp4430_vana = { 
	.constraints = {

		.min_uV			= 2100000,

		.max_uV			= 2100000,

		.apply_uV		= true,

		.valid_modes_mask	= REGULATOR_MODE_NORMAL

					| REGULATOR_MODE_STANDBY,

		.valid_ops_mask	 = REGULATOR_CHANGE_MODE
@@ -445,7 +444,6 @@ static struct regulator_init_data sdp4430_vcxio = { 
	.constraints = {

		.min_uV			= 1800000,

		.max_uV			= 1800000,

		.apply_uV		= true,

		.valid_modes_mask	= REGULATOR_MODE_NORMAL

					| REGULATOR_MODE_STANDBY,

		.valid_ops_mask	 = REGULATOR_CHANGE_MODE
@@ -457,7 +455,6 @@ static struct regulator_init_data sdp4430_vdac = { 
	.constraints = {

		.min_uV			= 1800000,

		.max_uV			= 1800000,

		.apply_uV		= true,

		.valid_modes_mask	= REGULATOR_MODE_NORMAL

					| REGULATOR_MODE_STANDBY,

		.valid_ops_mask	 = REGULATOR_CHANGE_MODE

arch/arm/mach-omap2/board-omap4panda.c

+0 −3
Original line number Diff line number Diff line
@@ -304,7 +304,6 @@ static struct regulator_init_data omap4_panda_vana = { 
	.constraints = {

		.min_uV			= 2100000,

		.max_uV			= 2100000,

		.apply_uV		= true,

		.valid_modes_mask	= REGULATOR_MODE_NORMAL

					| REGULATOR_MODE_STANDBY,

		.valid_ops_mask	 = REGULATOR_CHANGE_MODE
@@ -316,7 +315,6 @@ static struct regulator_init_data omap4_panda_vcxio = { 
	.constraints = {

		.min_uV			= 1800000,

		.max_uV			= 1800000,

		.apply_uV		= true,

		.valid_modes_mask	= REGULATOR_MODE_NORMAL

					| REGULATOR_MODE_STANDBY,

		.valid_ops_mask	 = REGULATOR_CHANGE_MODE
@@ -328,7 +326,6 @@ static struct regulator_init_data omap4_panda_vdac = { 
	.constraints = {

		.min_uV			= 1800000,

		.max_uV			= 1800000,

		.apply_uV		= true,

		.valid_modes_mask	= REGULATOR_MODE_NORMAL

					| REGULATOR_MODE_STANDBY,

		.valid_ops_mask	 = REGULATOR_CHANGE_MODE