Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 52db9819 authored by Axel Lin's avatar Axel Lin Committed by Dmitry Torokhov
Browse files

Input: lm8323 - add missing device_remove_file for dev_attr_time 



Add missing device_remove_file() for dev_attr_time in lm8323_remove().
Also calling device_remove_file() in lm8323_probe() error path to
remove sysfs attribute file.

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Signed-off-by: default avatarDmitry Torokhov <dtor@mail.ru>
parent 3f27757a

drivers/input/keyboard/lm8323.c

+7 −2
Original line number Diff line number Diff line
@@ -754,8 +754,11 @@ fail3: 
	device_remove_file(&client->dev, &dev_attr_disable_kp);

fail2:

	while (--pwm >= 0)

		if (lm->pwm[pwm].enabled)

		if (lm->pwm[pwm].enabled) {

			device_remove_file(lm->pwm[pwm].cdev.dev,

					   &dev_attr_time);

			led_classdev_unregister(&lm->pwm[pwm].cdev);

		}

fail1:

	input_free_device(idev);

	kfree(lm);
@@ -775,8 +778,10 @@ static int __devexit lm8323_remove(struct i2c_client *client) 
	device_remove_file(&lm->client->dev, &dev_attr_disable_kp);



	for (i = 0; i < 3; i++)

		if (lm->pwm[i].enabled)

		if (lm->pwm[i].enabled) {

			device_remove_file(lm->pwm[i].cdev.dev, &dev_attr_time);

			led_classdev_unregister(&lm->pwm[i].cdev);

		}



	kfree(lm);