Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 52ca15b7 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda - Avoid output amp manipulation to digital mic pins 



Don't set amp-out values to pins without PINCAP_OUT capability,
which are usually assigned for digital mics on ALC663/ALC272.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 234b4346

sound/pci/hda/patch_realtek.c

+8 −1
Original line number Diff line number Diff line
@@ -16750,6 +16750,12 @@ static int alc662_is_input_pin(struct hda_codec *codec, hda_nid_t nid) 
	return (pincap & AC_PINCAP_IN) != 0;

}













static int alc662_is_output_pin(struct hda_codec *codec, hda_nid_t nid)













{













	unsigned int pincap = snd_hda_param_read(codec, nid, AC_PAR_PIN_CAP);













	return (pincap & AC_PINCAP_OUT) != 0;













}



























/* create playback/capture controls for input pins */















static int alc662_auto_create_analog_input_ctls(struct hda_codec *codec,















						const struct auto_pin_cfg *cfg)










@@ -16837,7 +16843,8 @@ static void alc662_auto_init_analog_input(struct hda_codec *codec)













		hda_nid_t nid = spec->autocfg.input_pins[i];















		if (alc662_is_input_pin(codec, nid)) {















			alc_set_input_pin(codec, nid, i);













			if (nid != ALC662_PIN_CD_NID)













			if (nid != ALC662_PIN_CD_NID &&













			    alc662_is_output_pin(codec, nid))















				snd_hda_codec_write(codec, nid, 0,















						    AC_VERB_SET_AMP_GAIN_MUTE,















						    AMP_OUT_MUTE);