Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 52a6966c authored by Wolfram Sang's avatar Wolfram Sang Committed by Greg Kroah-Hartman
Browse files

usb: core: bail out if user gives an unknown RefId when using new_id 



If users use the new RefId feature of new_id, give them an error message
if they provided an unknown reference. That helps detecting typos.

Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2fc82c2d

drivers/usb/core/driver.c

+6 −3
Original line number Diff line number Diff line
@@ -74,10 +74,13 @@ ssize_t usb_store_new_id(struct usb_dynids *dynids, 
		const struct usb_device_id *id = id_table;



		for (; id->match_flags; id++)

			if (id->idVendor == refVendor && id->idProduct == refProduct) {

				dynid->id.driver_info = id->driver_info;

			if (id->idVendor == refVendor && id->idProduct == refProduct)

				break;

			}



		if (id->match_flags)

			dynid->id.driver_info = id->driver_info;

		else

			return -ENODEV;

	}



	spin_lock(&dynids->lock);