Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 526cc3ec authored by Osvaldo Banuelos's avatar Osvaldo Banuelos Committed by Gerrit - the friendly Code Review server
Browse files

regulator: kryo-regulator: program LDO Vref register before switching modes 



The LDO Vref register must be set prior to triggering a mode switch,
even if the value programmed in the Vref register has not changed.
Call kryo_set_ldo_volt() when changing modes to satisfy this
requirement.

Change-Id: I43ab9c59046fc9a5915cdc8f54f1e2821b047a34
Signed-off-by: default avatarOsvaldo Banuelos <osvaldob@codeaurora.org>
parent bc1ff73c

drivers/regulator/kryo-regulator.c

+14 −7
Original line number Diff line number Diff line
@@ -117,19 +117,17 @@ static bool is_between(int left, int right, int value) 
static void kryo_masked_write(struct kryo_regulator *kvreg,

			      int reg, u32 mask, u32 val)

{

	u32 reg_val, orig_val;

	u32 reg_val;



	reg_val = orig_val = readl_relaxed(kvreg->reg_base + reg);

	reg_val = readl_relaxed(kvreg->reg_base + reg);

	reg_val &= ~mask;

	reg_val |= (val & mask);



	if (reg_val != orig_val) {

	writel_relaxed(reg_val, kvreg->reg_base + reg);



	/* Ensure write above completes */

	mb();

}

}



static inline void kryo_pm_apcc_masked_write(struct kryo_regulator *kvreg,

			       int reg, u32 mask, u32 val)
@@ -350,6 +348,15 @@ static int kryo_regulator_set_bypass(struct regulator_dev *rdev, 
	int rc;



	mutex_lock(&kvreg->lock);



	/*

	 * LDO Vref voltage must be programmed before switching

	 * modes to ensure stable operation.

	 */

	rc = kryo_set_ldo_volt(kvreg, kvreg->volt);

	if (rc)

		kvreg_err(kvreg, "set voltage failed, rc=%d\n", rc);



	rc = kryo_configure_mode(kvreg, enable);

	if (rc)

		kvreg_err(kvreg, "could not configure to %s mode\n",