Commit 5204f5e3 authored Sep 05, 2011 by Mark Brown

regmap: Remove bitrotted module_put()s

The conversion to per bus type registration functions means we don't need
to do module_get()s to hold the bus types in memory (their users will link
to them) so we removed all those calls. This left module_put() calls in
the cleanup paths which aren't needed and which cause unbalanced puts if
we ever try to unload anything.

Reported-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

parent b33f9cbd

drivers/base/regmap/regmap.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -168,13 +168,11 @@ struct regmap regmap_init(struct device dev,
		map->work_buf = kmalloc(map->format.buf_size, GFP_KERNEL);
		if (map->work_buf == NULL) {
		ret = -ENOMEM;
		goto err_bus;
		goto err_map;
		}

		return map;

		err_bus:
		module_put(map->bus->owner);
		err_map:
		kfree(map);
		err:
		@@ -188,7 +186,6 @@ EXPORT_SYMBOL_GPL(regmap_init);
		void regmap_exit(struct regmap *map)
		{
		kfree(map->work_buf);
		module_put(map->bus->owner);
		kfree(map);
		}
		EXPORT_SYMBOL_GPL(regmap_exit);