Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 50fa46b2 authored by Roel Kluin's avatar Roel Kluin Committed by Mauro Carvalho Chehab
Browse files

V4L/DVB (7733): blackbird_find_mailbox negative return ignored in blackbird_initialize_codec() 



dev->mailbox is unsigned. so a negative return goes unnoticed

Signed-off-by: default avatarRoel Kluin <12o3l@tiscali.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
parent 63b79cfa

drivers/media/video/cx88/cx88-blackbird.c

+4 −2
Original line number Diff line number Diff line
@@ -546,10 +546,12 @@ static int blackbird_initialize_codec(struct cx8802_dev *dev) 
		if (retval < 0)

			return retval;



		dev->mailbox = blackbird_find_mailbox(dev);

		if (dev->mailbox < 0)

		retval = blackbird_find_mailbox(dev);

		if (retval < 0)

			return -1;



		dev->mailbox = retval;



		retval = blackbird_api_cmd(dev, CX2341X_ENC_PING_FW, 0, 0); /* ping */

		if (retval < 0) {

			dprintk(0, "ERROR: Firmware ping failed!\n");