Commit 5074b85b authored Nov 02, 2012 by Jan Beulich Committed by Thomas Gleixner Nov 02, 2012

x86: hpet: Fix inverted return value check in arch_setup_hpet_msi()



setup_hpet_msi_remapped() returns a negative error indicator on error
- check for this rather than for a boolean false indication, and pass
on that error code rather than a meaningless "-1".

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Link: http://lkml.kernel.org/r/5093E00D02000078000A60E2@nat28.tlf.novell.com


Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent 6acf5a8c

arch/x86/kernel/apic/io_apic.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -3317,8 +3317,9 @@ int arch_setup_hpet_msi(unsigned int irq, unsigned int id)
		int ret;

		if (irq_remapping_enabled) {
		if (!setup_hpet_msi_remapped(irq, id))
		return -1;
		ret = setup_hpet_msi_remapped(irq, id);
		if (ret)
		return ret;
		}

		ret = msi_compose_msg(NULL, irq, &msg, id);