Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 506026c3 authored by Jeff Layton's avatar Jeff Layton Committed by Trond Myklebust
Browse files

sunrpc: clarify comments on rpc_make_runnable 



rpc_make_runnable is not generally called with the queue lock held, unless
it's waking up a task that has been sitting on a waitqueue. This is safe
when the task has not entered the FSM yet, but the comments don't really
spell this out.

Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent 159e0561

net/sunrpc/sched.c

+3 −2
Original line number Diff line number Diff line
@@ -300,8 +300,9 @@ EXPORT_SYMBOL_GPL(__rpc_wait_for_completion_task); 
/*

 * Make an RPC task runnable.

 *

 * Note: If the task is ASYNC, this must be called with

 * the spinlock held to protect the wait queue operation.

 * Note: If the task is ASYNC, and is being made runnable after sitting on an

 * rpc_wait_queue, this must be called with the queue spinlock held to protect

 * the wait queue operation.

 */

static void rpc_make_runnable(struct rpc_task *task)

{