Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 504131c4 authored by Naseer Ahmed's avatar Naseer Ahmed Committed by Gerrit - the friendly Code Review server
Browse files

mdss: Fix solid fill unpack pattern 



Most users expect RGB order instead of RBG.
When userspace gives an ARGB color, the blue and green
channels are swapped.
Adjust pattern to match ARGB instead of ARBG.

CRs-Fixed: 1045472 1084507
Change-Id: I413ded858df41496d26362602abf3eb40c3cc1ed
Signed-off-by: default avatarNaseer Ahmed <naseer@codeaurora.org>
parent 897f20c4

drivers/video/msm/mdss/mdss_mdp_pipe.c

+2 −2
Original line number Diff line number Diff line 
/* Copyright (c) 2012-2016, The Linux Foundation. All rights reserved.

/* Copyright (c) 2012-2016, 2018, The Linux Foundation. All rights reserved.

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 and
@@ -2304,7 +2304,7 @@ static int mdss_mdp_pipe_solidfill_setup(struct mdss_mdp_pipe *pipe) 


	/* support ARGB color format only */

	unpack = (C3_ALPHA << 24) | (C2_R_Cr << 16) |

		(C1_B_Cb << 8) | (C0_G_Y << 0);

		(C0_G_Y << 8) | (C1_B_Cb << 0);

	if (pipe->scaler.enable)

		opmode |= (1 << 31);