Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4fd27358 authored by Hannes Eder's avatar Hannes Eder Committed by Ingo Molnar
Browse files

tracing: fix sparse warnings: make symbols static 



Impact: make global variables and a global function static

The function '__trace_userstack' does not seem to have a caller, so it
is commented out.

Fix this sparse warnings:
  kernel/trace/trace.c:82:5: warning: symbol 'tracing_disabled' was not declared. Should it be static?
  kernel/trace/trace.c:600:10: warning: symbol 'trace_record_cmdline_disabled' was not declared. Should it be static?
  kernel/trace/trace.c:957:6: warning: symbol '__trace_userstack' was not declared. Should it be static?
  kernel/trace/trace.c:1694:5: warning: symbol 'tracing_release' was not declared. Should it be static?

Signed-off-by: default avatarHannes Eder <hannes@hanneseder.net>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 4040068d

kernel/trace/trace.c

+6 −4
Original line number Diff line number Diff line
@@ -80,7 +80,7 @@ static int dummy_set_flag(u32 old_flags, u32 bit, int set) 
 * of the tracer is successful. But that is the only place that sets

 * this back to zero.

 */

int tracing_disabled = 1;

static int tracing_disabled = 1;



static DEFINE_PER_CPU(local_t, ftrace_cpu_disabled);
@@ -626,7 +626,7 @@ static int cmdline_idx; 
static DEFINE_SPINLOCK(trace_cmdline_lock);



/* temporary disable recording */

atomic_t trace_record_cmdline_disabled __read_mostly;

static atomic_t trace_record_cmdline_disabled __read_mostly;



static void trace_init_cmdlines(void)

{
@@ -983,10 +983,12 @@ static void ftrace_trace_userstack(struct trace_array *tr, 
#endif

}



void __trace_userstack(struct trace_array *tr, unsigned long flags)

#ifdef UNUSED

static void __trace_userstack(struct trace_array *tr, unsigned long flags)

{

	ftrace_trace_userstack(tr, flags, preempt_count());

}

#endif /* UNUSED */



static void

ftrace_trace_special(void *__tr,
@@ -1720,7 +1722,7 @@ int tracing_open_generic(struct inode *inode, struct file *filp) 
	return 0;

}



int tracing_release(struct inode *inode, struct file *file)

static int tracing_release(struct inode *inode, struct file *file)

{

	struct seq_file *m = (struct seq_file *)file->private_data;

	struct trace_iterator *iter = m->private;