Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4e1db5e5 authored by Linus Torvalds's avatar Linus Torvalds
Browse files
* 'x86-mce-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip:
  apic, amd: Make firmware bug messages more meaningful
  mce, amd: Remove goto in threshold_create_device()
  mce, amd: Add helper functions to setup APIC
  mce, amd: Shorten local variables mci_misc_{hi,lo}
  mce, amd: Implement mce_threshold_block_init() helper function
parents 37d9a8c5 eb48c9cb
Loading
Loading
Loading
Loading
+8 −7
Original line number Original line Diff line number Diff line
@@ -431,17 +431,18 @@ int setup_APIC_eilvt(u8 offset, u8 vector, u8 msg_type, u8 mask)
	reserved = reserve_eilvt_offset(offset, new);
	reserved = reserve_eilvt_offset(offset, new);


	if (reserved != new) {
	if (reserved != new) {
		pr_err(FW_BUG "cpu %d, try to setup vector 0x%x, but "
		pr_err(FW_BUG "cpu %d, try to use APIC%lX (LVT offset %d) for "
		       "vector 0x%x was already reserved by another core, "
		       "vector 0x%x, but the register is already in use for "
		       "APIC%lX=0x%x\n",
		       "vector 0x%x on another cpu\n",
		       smp_processor_id(), new, reserved, reg, old);
		       smp_processor_id(), reg, offset, new, reserved);
		return -EINVAL;
		return -EINVAL;
	}
	}


	if (!eilvt_entry_is_changeable(old, new)) {
	if (!eilvt_entry_is_changeable(old, new)) {
		pr_err(FW_BUG "cpu %d, try to setup vector 0x%x but "
		pr_err(FW_BUG "cpu %d, try to use APIC%lX (LVT offset %d) for "
		       "register already in use, APIC%lX=0x%x\n",
		       "vector 0x%x, but the register is already in use for "
		       smp_processor_id(), new, reg, old);
		       "vector 0x%x on this cpu\n",
		       smp_processor_id(), reg, offset, new, old);
		return -EBUSY;
		return -EBUSY;
	}
	}


+77 −58
Original line number Original line Diff line number Diff line
@@ -31,8 +31,6 @@
#include <asm/mce.h>
#include <asm/mce.h>
#include <asm/msr.h>
#include <asm/msr.h>


#define PFX               "mce_threshold: "
#define VERSION           "version 1.1.1"
#define NR_BANKS          6
#define NR_BANKS          6
#define NR_BLOCKS         9
#define NR_BLOCKS         9
#define THRESHOLD_MAX     0xFFF
#define THRESHOLD_MAX     0xFFF
@@ -59,12 +57,6 @@ struct threshold_block {
	struct list_head	miscj;
	struct list_head	miscj;
};
};


/* defaults used early on boot */
static struct threshold_block threshold_defaults = {
	.interrupt_enable	= 0,
	.threshold_limit	= THRESHOLD_MAX,
};

struct threshold_bank {
struct threshold_bank {
	struct kobject		*kobj;
	struct kobject		*kobj;
	struct threshold_block	*blocks;
	struct threshold_block	*blocks;
@@ -89,50 +81,101 @@ static void amd_threshold_interrupt(void);
struct thresh_restart {
struct thresh_restart {
	struct threshold_block	*b;
	struct threshold_block	*b;
	int			reset;
	int			reset;
	int			set_lvt_off;
	int			lvt_off;
	u16			old_limit;
	u16			old_limit;
};
};


static int lvt_off_valid(struct threshold_block *b, int apic, u32 lo, u32 hi)
{
	int msr = (hi & MASK_LVTOFF_HI) >> 20;

	if (apic < 0) {
		pr_err(FW_BUG "cpu %d, failed to setup threshold interrupt "
		       "for bank %d, block %d (MSR%08X=0x%x%08x)\n", b->cpu,
		       b->bank, b->block, b->address, hi, lo);
		return 0;
	}

	if (apic != msr) {
		pr_err(FW_BUG "cpu %d, invalid threshold interrupt offset %d "
		       "for bank %d, block %d (MSR%08X=0x%x%08x)\n",
		       b->cpu, apic, b->bank, b->block, b->address, hi, lo);
		return 0;
	}

	return 1;
};

/* must be called with correct cpu affinity */
/* must be called with correct cpu affinity */
/* Called via smp_call_function_single() */
/* Called via smp_call_function_single() */
static void threshold_restart_bank(void *_tr)
static void threshold_restart_bank(void *_tr)
{
{
	struct thresh_restart *tr = _tr;
	struct thresh_restart *tr = _tr;
	u32 mci_misc_hi, mci_misc_lo;
	u32 hi, lo;


	rdmsr(tr->b->address, mci_misc_lo, mci_misc_hi);
	rdmsr(tr->b->address, lo, hi);


	if (tr->b->threshold_limit < (mci_misc_hi & THRESHOLD_MAX))
	if (tr->b->threshold_limit < (hi & THRESHOLD_MAX))
		tr->reset = 1;	/* limit cannot be lower than err count */
		tr->reset = 1;	/* limit cannot be lower than err count */


	if (tr->reset) {		/* reset err count and overflow bit */
	if (tr->reset) {		/* reset err count and overflow bit */
		mci_misc_hi =
		hi =
		    (mci_misc_hi & ~(MASK_ERR_COUNT_HI | MASK_OVERFLOW_HI)) |
		    (hi & ~(MASK_ERR_COUNT_HI | MASK_OVERFLOW_HI)) |
		    (THRESHOLD_MAX - tr->b->threshold_limit);
		    (THRESHOLD_MAX - tr->b->threshold_limit);
	} else if (tr->old_limit) {	/* change limit w/o reset */
	} else if (tr->old_limit) {	/* change limit w/o reset */
		int new_count = (mci_misc_hi & THRESHOLD_MAX) +
		int new_count = (hi & THRESHOLD_MAX) +
		    (tr->old_limit - tr->b->threshold_limit);
		    (tr->old_limit - tr->b->threshold_limit);


		mci_misc_hi = (mci_misc_hi & ~MASK_ERR_COUNT_HI) |
		hi = (hi & ~MASK_ERR_COUNT_HI) |
		    (new_count & THRESHOLD_MAX);
		    (new_count & THRESHOLD_MAX);
	}
	}


	if (tr->set_lvt_off) {
		if (lvt_off_valid(tr->b, tr->lvt_off, lo, hi)) {
			/* set new lvt offset */
			hi &= ~MASK_LVTOFF_HI;
			hi |= tr->lvt_off << 20;
		}
	}

	tr->b->interrupt_enable ?
	tr->b->interrupt_enable ?
	    (mci_misc_hi = (mci_misc_hi & ~MASK_INT_TYPE_HI) | INT_TYPE_APIC) :
	    (hi = (hi & ~MASK_INT_TYPE_HI) | INT_TYPE_APIC) :
	    (mci_misc_hi &= ~MASK_INT_TYPE_HI);
	    (hi &= ~MASK_INT_TYPE_HI);

	hi |= MASK_COUNT_EN_HI;
	wrmsr(tr->b->address, lo, hi);
}

static void mce_threshold_block_init(struct threshold_block *b, int offset)
{
	struct thresh_restart tr = {
		.b			= b,
		.set_lvt_off		= 1,
		.lvt_off		= offset,
	};

	b->threshold_limit		= THRESHOLD_MAX;
	threshold_restart_bank(&tr);
};

static int setup_APIC_mce(int reserved, int new)
{
	if (reserved < 0 && !setup_APIC_eilvt(new, THRESHOLD_APIC_VECTOR,
					      APIC_EILVT_MSG_FIX, 0))
		return new;


	mci_misc_hi |= MASK_COUNT_EN_HI;
	return reserved;
	wrmsr(tr->b->address, mci_misc_lo, mci_misc_hi);
}
}


/* cpu init entry point, called from mce.c with preempt off */
/* cpu init entry point, called from mce.c with preempt off */
void mce_amd_feature_init(struct cpuinfo_x86 *c)
void mce_amd_feature_init(struct cpuinfo_x86 *c)
{
{
	struct threshold_block b;
	unsigned int cpu = smp_processor_id();
	unsigned int cpu = smp_processor_id();
	u32 low = 0, high = 0, address = 0;
	u32 low = 0, high = 0, address = 0;
	unsigned int bank, block;
	unsigned int bank, block;
	struct thresh_restart tr;
	int offset = -1;
	int lvt_off = -1;
	u8 offset;


	for (bank = 0; bank < NR_BANKS; ++bank) {
	for (bank = 0; bank < NR_BANKS; ++bank) {
		for (block = 0; block < NR_BLOCKS; ++block) {
		for (block = 0; block < NR_BLOCKS; ++block) {
@@ -163,39 +206,16 @@ void mce_amd_feature_init(struct cpuinfo_x86 *c)
			if (shared_bank[bank] && c->cpu_core_id)
			if (shared_bank[bank] && c->cpu_core_id)
				break;
				break;
#endif
#endif
			offset = (high & MASK_LVTOFF_HI) >> 20;
			offset = setup_APIC_mce(offset,
			if (lvt_off < 0) {
						(high & MASK_LVTOFF_HI) >> 20);
				if (setup_APIC_eilvt(offset,
						     THRESHOLD_APIC_VECTOR,
						     APIC_EILVT_MSG_FIX, 0)) {
					pr_err(FW_BUG "cpu %d, failed to "
					       "setup threshold interrupt "
					       "for bank %d, block %d "
					       "(MSR%08X=0x%x%08x)",
					       smp_processor_id(), bank, block,
					       address, high, low);
					continue;
				}
				lvt_off = offset;
			} else if (lvt_off != offset) {
				pr_err(FW_BUG "cpu %d, invalid threshold "
				       "interrupt offset %d for bank %d,"
				       "block %d (MSR%08X=0x%x%08x)",
				       smp_processor_id(), lvt_off, bank,
				       block, address, high, low);
				continue;
			}


			high &= ~MASK_LVTOFF_HI;
			memset(&b, 0, sizeof(b));
			high |= lvt_off << 20;
			b.cpu		= cpu;
			wrmsr(address, low, high);
			b.bank		= bank;

			b.block		= block;
			threshold_defaults.address = address;
			b.address	= address;
			tr.b = &threshold_defaults;
			tr.reset = 0;
			tr.old_limit = 0;
			threshold_restart_bank(&tr);


			mce_threshold_block_init(&b, offset);
			mce_threshold_vector = amd_threshold_interrupt;
			mce_threshold_vector = amd_threshold_interrupt;
		}
		}
	}
	}
@@ -298,9 +318,8 @@ store_interrupt_enable(struct threshold_block *b, const char *buf, size_t size)


	b->interrupt_enable = !!new;
	b->interrupt_enable = !!new;


	memset(&tr, 0, sizeof(tr));
	tr.b		= b;
	tr.b		= b;
	tr.reset	= 0;
	tr.old_limit	= 0;


	smp_call_function_single(b->cpu, threshold_restart_bank, &tr, 1);
	smp_call_function_single(b->cpu, threshold_restart_bank, &tr, 1);


@@ -321,10 +340,10 @@ store_threshold_limit(struct threshold_block *b, const char *buf, size_t size)
	if (new < 1)
	if (new < 1)
		new = 1;
		new = 1;


	memset(&tr, 0, sizeof(tr));
	tr.old_limit = b->threshold_limit;
	tr.old_limit = b->threshold_limit;
	b->threshold_limit = new;
	b->threshold_limit = new;
	tr.b = b;
	tr.b = b;
	tr.reset = 0;


	smp_call_function_single(b->cpu, threshold_restart_bank, &tr, 1);
	smp_call_function_single(b->cpu, threshold_restart_bank, &tr, 1);


@@ -603,9 +622,9 @@ static __cpuinit int threshold_create_device(unsigned int cpu)
			continue;
			continue;
		err = threshold_create_bank(cpu, bank);
		err = threshold_create_bank(cpu, bank);
		if (err)
		if (err)
			goto out;
			return err;
	}
	}
out:

	return err;
	return err;
}
}


+1 −0
Original line number Original line Diff line number Diff line
@@ -610,6 +610,7 @@ static int force_ibs_eilvt_setup(void)
		ret = setup_ibs_ctl(i);
		ret = setup_ibs_ctl(i);
		if (ret)
		if (ret)
			return ret;
			return ret;
		pr_err(FW_BUG "using offset %d for IBS interrupts\n", i);
		return 0;
		return 0;
	}
	}