Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4dca20ef authored by Carsten Emde's avatar Carsten Emde Committed by Daniel Vetter
Browse files

drm/i915: panel: invert brightness via quirk 



A machine may need to invert the panel backlight brightness value. This
patch adds the infrastructure for a quirk to do so.

Signed-off-by: default avatarCarsten Emde <C.Emde@osadl.org>
Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 7bd90909

Documentation/kernel-parameters.txt

+11 −6
Original line number Original line Diff line number Diff line
@@ -967,14 +967,19 @@ bytes respectively. Such letter suffixes can also be entirely omitted. 
	i8k.restricted	[HW] Allow controlling fans only if SYS_ADMIN

	i8k.restricted	[HW] Allow controlling fans only if SYS_ADMIN

			capability is set.

			capability is set.





	i915.invert_brightness

	i915.invert_brightness=

			[DRM] Invert the sense of the variable that is used to

			[DRM] Invert the sense of the variable that is used to

			set the brightness of the panel backlight. Normally a

			set the brightness of the panel backlight. Normally a

			value of 0 indicates backlight switched off, and the

			brightness value of 0 indicates backlight switched off,

			maximum value sets the backlight to maximum brightness.

			and the maximum of the brightness value sets the backlight

			If this parameter is specified, a value of 0 sets the

			to maximum brightness. If this parameter is set to 0

			backlight to maximum brightness, and the maximum value

			(default) and the machine requires it, or this parameter

			switches the backlight off.

			is set to 1, a brightness value of 0 sets the backlight

			to maximum brightness, and the maximum of the brightness

			value switches the backlight off.

			-1 -- never invert brightness

			 0 -- machine default

			 1 -- force brightness inversion





	icn=		[HW,ISDN]

	icn=		[HW,ISDN]

			Format: <io>[,<membase>[,<icn_id>[,<icn_id2>]]]

			Format: <io>[,<membase>[,<icn_id>[,<icn_id2>]]]

drivers/gpu/drm/i915/i915_drv.h

+1 −0
Original line number Original line Diff line number Diff line
@@ -295,6 +295,7 @@ enum intel_pch { 




#define QUIRK_PIPEA_FORCE (1<<0)

#define QUIRK_PIPEA_FORCE (1<<0)

#define QUIRK_LVDS_SSC_DISABLE (1<<1)

#define QUIRK_LVDS_SSC_DISABLE (1<<1)

#define QUIRK_INVERT_BRIGHTNESS (1<<2)





struct intel_fbdev;

struct intel_fbdev;

struct intel_fbc_work;

struct intel_fbc_work;

drivers/gpu/drm/i915/intel_display.c

+9 −0
Original line number Original line Diff line number Diff line
@@ -9020,6 +9020,15 @@ static void quirk_ssc_force_disable(struct drm_device *dev) 
	dev_priv->quirks |= QUIRK_LVDS_SSC_DISABLE;

	dev_priv->quirks |= QUIRK_LVDS_SSC_DISABLE;

}

}





/*

 * A machine may need to invert the panel backlight brightness value

 */

static void quirk_invert_brightness(struct drm_device *dev)

{

	struct drm_i915_private *dev_priv = dev->dev_private;

	dev_priv->quirks |= QUIRK_INVERT_BRIGHTNESS;

}



struct intel_quirk {

struct intel_quirk {

	int device;

	int device;

	int subsystem_vendor;

	int subsystem_vendor;

drivers/gpu/drm/i915/intel_panel.c

+11 −4
Original line number Original line Diff line number Diff line
@@ -192,15 +192,22 @@ u32 intel_panel_get_max_backlight(struct drm_device *dev) 
	return max;

	return max;

}

}





static bool i915_panel_invert_brightness;

static int i915_panel_invert_brightness;

MODULE_PARM_DESC(invert_brightness, "Invert backlight brightness, please "

MODULE_PARM_DESC(invert_brightness, "Invert backlight brightness "

	"(-1 force normal, 0 machine defaults, 1 force inversion), please "

	"report PCI device ID, subsystem vendor and subsystem device ID "

	"report PCI device ID, subsystem vendor and subsystem device ID "

	"to dri-devel@lists.freedesktop.org, if your machine needs it. "

	"to dri-devel@lists.freedesktop.org, if your machine needs it. "

	"It will then be included in an upcoming module version.");

	"It will then be included in an upcoming module version.");

module_param_named(invert_brightness, i915_panel_invert_brightness, bool, 0600);

module_param_named(invert_brightness, i915_panel_invert_brightness, int, 0600);

static u32 intel_panel_compute_brightness(struct drm_device *dev, u32 val)

static u32 intel_panel_compute_brightness(struct drm_device *dev, u32 val)

{

{

	if (i915_panel_invert_brightness)

	struct drm_i915_private *dev_priv = dev->dev_private;



	if (i915_panel_invert_brightness < 0)

		return val;



	if (i915_panel_invert_brightness > 0 ||

	    dev_priv->quirks & QUIRK_INVERT_BRIGHTNESS)

		return intel_panel_get_max_backlight(dev) - val;

		return intel_panel_get_max_backlight(dev) - val;





	return val;

	return val;