Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4d9f6cff authored by Anton Vasilyev's avatar Anton Vasilyev Committed by Greg Kroah-Hartman
Browse files

tty: rocket: Fix possible buffer overwrite on register_PCI 



[ Upstream commit 0419056ec8fd01ddf5460d2dba0491aad22657dd ]

If number of isa and pci boards exceed NUM_BOARDS on the path
rp_init()->init_PCI()->register_PCI() then buffer overwrite occurs
in register_PCI() on assign rcktpt_io_addr[i].

The patch adds check on upper bound for index of registered
board in register_PCI.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: default avatarAnton Vasilyev <vasilyev@ispras.ru>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9b48a687

drivers/tty/rocket.c

+1 −1
Original line number Diff line number Diff line
@@ -1928,7 +1928,7 @@ static __init int register_PCI(int i, struct pci_dev *dev) 
	ByteIO_t UPCIRingInd = 0;



	if (!dev || !pci_match_id(rocket_pci_ids, dev) ||

	    pci_enable_device(dev))

	    pci_enable_device(dev) || i >= NUM_BOARDS)

		return 0;



	rcktpt_io_addr[i] = pci_resource_start(dev, 0);