Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c8d558a authored by Roberto Alcântara's avatar Roberto Alcântara Committed by Mauro Carvalho Chehab
Browse files

[media] smscoreapi: Make Siano firmware load more verbose 



If firmware load fails, report it as an error.

Signed-off-by: default avatarRoberto Alcantara <roberto@eletronica.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent a242f426

drivers/media/common/siano/smscoreapi.c

+3 −3
Original line number Diff line number Diff line
@@ -1154,7 +1154,7 @@ static int smscore_load_firmware_from_file(struct smscore_device_t *coredev, 


	char *fw_filename = smscore_get_fw_filename(coredev, mode);

	if (!fw_filename) {

		sms_info("mode %d not supported on this device", mode);

		sms_err("mode %d not supported on this device", mode);

		return -ENOENT;

	}

	sms_debug("Firmware name: %s", fw_filename);
@@ -1165,14 +1165,14 @@ static int smscore_load_firmware_from_file(struct smscore_device_t *coredev, 


	rc = request_firmware(&fw, fw_filename, coredev->device);

	if (rc < 0) {

		sms_info("failed to open \"%s\"", fw_filename);

		sms_err("failed to open firmware file \"%s\"", fw_filename);

		return rc;

	}

	sms_info("read fw %s, buffer size=0x%zx", fw_filename, fw->size);

	fw_buf = kmalloc(ALIGN(fw->size, SMS_ALLOC_ALIGNMENT),

			 GFP_KERNEL | GFP_DMA);

	if (!fw_buf) {

		sms_info("failed to allocate firmware buffer");

		sms_err("failed to allocate firmware buffer");

		return -ENOMEM;

	}

	memcpy(fw_buf, fw->data, fw->size);