Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c55a462 authored by dingtianhong's avatar dingtianhong Committed by David S. Miller
Browse files

atm: slight optimization of addr compare 



Use possibly more efficient ether_addr_equal
instead of memcmp.

Cc: Chas Williams <chas@cmf.nrl.navy.mil>
Cc: linux-atm-general@lists.sourceforge.net
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Signed-off-by: default avatarDing Tianhong <dingtianhong@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 496d7e8e

drivers/atm/nicstar.c

+2 −2
Original line number Diff line number Diff line
@@ -52,6 +52,7 @@ 
#include <asm/io.h>

#include <asm/uaccess.h>

#include <linux/atomic.h>

#include <linux/etherdevice.h>

#include "nicstar.h"

#ifdef CONFIG_ATM_NICSTAR_USE_SUNI

#include "suni.h"
@@ -781,8 +782,7 @@ static int ns_init_card(int i, struct pci_dev *pcidev) 
	if (mac[i] == NULL || !mac_pton(mac[i], card->atmdev->esi)) {

		nicstar_read_eprom(card->membase, NICSTAR_EPROM_MAC_ADDR_OFFSET,

				   card->atmdev->esi, 6);

		if (memcmp(card->atmdev->esi, "\x00\x00\x00\x00\x00\x00", 6) ==

		    0) {

		if (ether_addr_equal(card->atmdev->esi, "\x00\x00\x00\x00\x00\x00")) {

			nicstar_read_eprom(card->membase,

					   NICSTAR_EPROM_MAC_ADDR_OFFSET_ALT,

					   card->atmdev->esi, 6);