Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c552a64 authored by Mathieu Poirier's avatar Mathieu Poirier Committed by Pablo Neira Ayuso
Browse files

netfilter: nfnetlink_acct: Fix memory leak 



Allocation of memory need only to happen once, that is
after the proper checks on the NFACCT_FLAGS have been
done.  Otherwise the code can return without freeing
already allocated memory.

Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 96b2e73c

net/netfilter/nfnetlink_acct.c

+0 −1
Original line number Diff line number Diff line
@@ -83,7 +83,6 @@ nfnl_acct_new(struct sock *nfnl, struct sk_buff *skb, 
		return -EBUSY;

	}



	nfacct = kzalloc(sizeof(struct nf_acct), GFP_KERNEL);

	if (tb[NFACCT_FLAGS]) {

		flags = ntohl(nla_get_be32(tb[NFACCT_FLAGS]));

		if (flags & ~NFACCT_F_QUOTA)