Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c38881f authored by Jan Kara's avatar Jan Kara Committed by Joel Becker
Browse files

ocfs2: Remove ocfs2_sync_inode() 



ocfs2_sync_inode() is used only from ocfs2_sync_file(). But all data has
already been written before calling ocfs2_sync_file() and ocfs2 doesn't use
inode's private_list for tracking metadata buffers thus sync_mapping_buffers()
is superfluous as well.

Signed-off-by: default avatarJan Kara <jack@suse.cz>
Acked-by: default avatarMark Fasheh <mfasheh@suse.com>
Signed-off-by: default avatarJoel Becker <joel.becker@oracle.com>
parent 83fd9c7f

fs/ocfs2/file.c

+0 −10
Original line number Diff line number Diff line
@@ -64,12 +64,6 @@ 


#include "buffer_head_io.h"



static int ocfs2_sync_inode(struct inode *inode)

{

	filemap_fdatawrite(inode->i_mapping);

	return sync_mapping_buffers(inode->i_mapping);

}



static int ocfs2_init_file_private(struct inode *inode, struct file *file)

{

	struct ocfs2_file_private *fp;
@@ -187,10 +181,6 @@ static int ocfs2_sync_file(struct file *file, int datasync) 
	mlog_entry("(0x%p, 0x%p, %d, '%.*s')\n", file, dentry, datasync,

		   dentry->d_name.len, dentry->d_name.name);



	err = ocfs2_sync_inode(dentry->d_inode);

	if (err)

		goto bail;



	if (datasync && !(inode->i_state & I_DIRTY_DATASYNC)) {

		/*

		 * We still have to flush drive's caches to get data to the