Commit 4c09b39c authored Feb 21, 2017 by Christophe JAILLET Committed by Greg Kroah-Hartman Dec 16, 2017

USB: gadgetfs: Fix a potential memory leak in 'dev_config()'




[ Upstream commit b6e7aeeaf235901c42ec35de4633c7c69501d303 ]

'kbuf' is allocated just a few lines above using 'memdup_user()'.
If the 'if (dev->buf)' test fails, this memory is never released.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 3e929173

drivers/usb/gadget/legacy/inode.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1921,8 +1921,10 @@ dev_config (struct file fd, const char __user buf, size_t len, loff_t *ptr)

		spin_lock_irq (&dev->lock);
		value = -EINVAL;
		if (dev->buf)
		if (dev->buf) {
		kfree(kbuf);
		goto fail;
		}
		dev->buf = kbuf;

		/* full or low speed config */