Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4bd8b4de authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

Staging: line6: NULL dereference in dev_err() 



"line6" hasn't been set at this point and we should be using
&interface->dev instead.

Gcc would have complained about this if it weren't for the fact that we
initialized line6 to NULL.  I removed the initialization.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarStefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent f75c0510

drivers/staging/line6/driver.c

+3 −3
Original line number Diff line number Diff line
@@ -726,8 +726,8 @@ static int line6_probe(struct usb_interface *interface, 
		       const struct usb_device_id *id)

{

	int devtype;

	struct usb_device *usbdev = NULL;

	struct usb_line6 *line6 = NULL;

	struct usb_device *usbdev;

	struct usb_line6 *line6;

	const struct line6_properties *properties;

	int devnum;

	int interface_number, alternate = 0;
@@ -936,7 +936,7 @@ static int line6_probe(struct usb_interface *interface, 
	}



	if (size == 0) {

		dev_err(line6->ifcdev,

		dev_err(&interface->dev,

			"driver bug: interface data size not set\n");

		ret = -ENODEV;

		goto err_put;