Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4a7267c9 authored by Hauke Mehrtens's avatar Hauke Mehrtens Committed by John W. Linville
Browse files

bcma: handle return value of pci_assign_resource 



This fixes the following warning:

  CC      drivers/bcma/driver_pci_host.o
drivers/bcma/driver_pci_host.c: In function 'bcma_core_pci_fixup_addresses':
drivers/bcma/driver_pci_host.c:555:23: error: ignoring return value of
'pci_assign_resource', declared with attribute warn_unused_result
[-Werror=unused-result]

Reported-by: default avatarArend van Spriel <arend@broadcom.com>
Signed-off-by: default avatarHauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 0751f865

drivers/bcma/driver_pci_host.c

+7 −3
Original line number Diff line number Diff line
@@ -538,7 +538,7 @@ DECLARE_PCI_FIXUP_EARLY(PCI_ANY_ID, PCI_ANY_ID, bcma_core_pci_fixup_pcibridge); 
static void bcma_core_pci_fixup_addresses(struct pci_dev *dev)

{

	struct resource *res;

	int pos;

	int pos, err;



	if (dev->bus->ops->read != bcma_core_pci_hostmode_read_config) {

		/* This is not a device on the PCI-core bridge. */
@@ -551,8 +551,12 @@ static void bcma_core_pci_fixup_addresses(struct pci_dev *dev) 


	for (pos = 0; pos < 6; pos++) {

		res = &dev->resource[pos];

		if (res->flags & (IORESOURCE_IO | IORESOURCE_MEM))

			pci_assign_resource(dev, pos);

		if (res->flags & (IORESOURCE_IO | IORESOURCE_MEM)) {

			err = pci_assign_resource(dev, pos);

			if (err)

				pr_err("PCI: Problem fixing up the addresses on %s\n",

				       pci_name(dev));

		}

	}

}

DECLARE_PCI_FIXUP_HEADER(PCI_ANY_ID, PCI_ANY_ID, bcma_core_pci_fixup_addresses);