Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 49b26e26 authored by Xiao Guangrong's avatar Xiao Guangrong Committed by Marcelo Tosatti
Browse files

KVM: MMU: do not record gfn in kvm_mmu_pte_write 



No need to record the gfn to verifier the pte has the same mode as
current vcpu, it's because we only speculatively update the pte only
if the pte and vcpu have the same mode

Signed-off-by: default avatarXiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Signed-off-by: default avatarAvi Kivity <avi@redhat.com>
parent 48c0e4e9

arch/x86/include/asm/kvm_host.h

+0 −1
Original line number Diff line number Diff line
@@ -336,7 +336,6 @@ struct kvm_vcpu_arch { 
	gfn_t last_pte_gfn;



	struct {

		gfn_t gfn;	/* presumed gfn during guest pte update */

		pfn_t pfn;	/* pfn corresponding to that gfn */

		unsigned long mmu_seq;

	} update_pte;

arch/x86/kvm/mmu.c

+2 −4
Original line number Diff line number Diff line
@@ -3228,7 +3228,6 @@ static void mmu_guess_page_from_pte_write(struct kvm_vcpu *vcpu, gpa_t gpa, 
		kvm_release_pfn_clean(pfn);

		return;

	}

	vcpu->arch.update_pte.gfn = gfn;

	vcpu->arch.update_pte.pfn = pfn;

}
@@ -3275,9 +3274,8 @@ void kvm_mmu_pte_write(struct kvm_vcpu *vcpu, gpa_t gpa, 


	/*

	 * Assume that the pte write on a page table of the same type

	 * as the current vcpu paging mode.  This is nearly always true

	 * (might be false while changing modes).  Note it is verified later

	 * by update_pte().

	 * as the current vcpu paging mode since we update the sptes only

	 * when they have the same mode.

	 */

	if ((is_pae(vcpu) && bytes == 4) || !new) {

		/* Handle a 32-bit guest writing two halves of a 64-bit gpte */

arch/x86/kvm/paging_tmpl.h

+0 −2
Original line number Diff line number Diff line
@@ -339,8 +339,6 @@ static void FNAME(update_pte)(struct kvm_vcpu *vcpu, struct kvm_mmu_page *sp, 


	pgprintk("%s: gpte %llx spte %p\n", __func__, (u64)gpte, spte);

	pte_access = sp->role.access & FNAME(gpte_access)(vcpu, gpte);

	if (gpte_to_gfn(gpte) != vcpu->arch.update_pte.gfn)

		return;

	pfn = vcpu->arch.update_pte.pfn;

	if (is_error_pfn(pfn))

		return;