Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4919c5e4 authored by Al Viro's avatar Al Viro
Browse files

fix race in d_splice_alias() 



rehashing the negative placeholder opens a race with d_lookup();
we unhash it almost immediately (by d_move()), but the race
window is there.  Since d_move() doesn't rely on target being
hashed, we don't need that d_rehash() at all.

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent bec1052e

fs/dcache.c

+0 −1
Original line number Diff line number Diff line
@@ -1222,7 +1222,6 @@ struct dentry *d_splice_alias(struct inode *inode, struct dentry *dentry) 
			BUG_ON(!(new->d_flags & DCACHE_DISCONNECTED));

			spin_unlock(&dcache_lock);

			security_d_instantiate(new, inode);

			d_rehash(dentry);

			d_move(new, dentry);

			iput(inode);

		} else {