Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4847cc07 authored by Federico Vaga's avatar Federico Vaga Committed by Greg Kroah-Hartman
Browse files

ipoctal: request_irq after configuration 



The request for an IRQ handler must be done after whole configuration. This
was not the case for this driver which request the IRQ in the middle of
the configuration. Sometimes, it happens that something is not completely
configured, we recieve an interrupt thus we stumble into troubles in the
IRQ handler.

Signed-off-by: default avatarFederico Vaga <federico.vaga@cern.ch>
Acked-by: default avatarSamuel Iglesias Gonsalvez <siglesias@igalia.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 968d04e8

drivers/ipack/devices/ipoctal.c

+8 −7
Original line number Diff line number Diff line
@@ -323,13 +323,6 @@ static int ipoctal_inst_slot(struct ipoctal *ipoctal, unsigned int bus_nr, 
			 &block_regs[i].w.imr);

	}



	/*

	 * IP-OCTAL has different addresses to copy its IRQ vector.

	 * Depending of the carrier these addresses are accesible or not.

	 * More info in the datasheet.

	 */

	ipoctal->dev->bus->ops->request_irq(ipoctal->dev,

				       ipoctal_irq_handler, ipoctal);

	/* Dummy write */

	iowrite8(1, ipoctal->mem8_space + 1);
@@ -390,6 +383,14 @@ static int ipoctal_inst_slot(struct ipoctal *ipoctal, unsigned int bus_nr, 
		dev_set_drvdata(tty_dev, channel);

	}



	/*

	 * IP-OCTAL has different addresses to copy its IRQ vector.

	 * Depending of the carrier these addresses are accesible or not.

	 * More info in the datasheet.

	 */

	ipoctal->dev->bus->ops->request_irq(ipoctal->dev,

				       ipoctal_irq_handler, ipoctal);



	return 0;

}