Commit 47de87a2 authored Feb 22, 2012 by Rabin Vincent Committed by Greg Kroah-Hartman Feb 24, 2012

staging: logger: hold mutex while removing reader

The readers list is traversed under the log->mutex lock
(for example from fix_up_readers()), but the deletion of
elements from this list is not being done under this lock.

Cc: Brian Swetland <swetland@google.com>
Cc: Dima Zavin <dima@android.com>
Signed-off-by: Rabin Vincent <rabin.vincent@stericsson.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6f6c4dc0

drivers/staging/android/logger.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -459,7 +459,12 @@ static int logger_release(struct inode ignored, struct file file)
		{
		if (file->f_mode & FMODE_READ) {
		struct logger_reader *reader = file->private_data;
		struct logger_log *log = reader->log;

		mutex_lock(&log->mutex);
		list_del(&reader->list);
		mutex_unlock(&log->mutex);

		kfree(reader);
		}