Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 47ac56db authored by Mike Snitzer's avatar Mike Snitzer Committed by James Bottomley
Browse files

[SCSI] scsi_error: classify some ILLEGAL_REQUEST sense as a permanent TARGET_ERROR 



Permanent target failures are non-retryable and should be classified as
TARGET_ERROR; otherwise dm-multipath will retry an IO request that will
always fail at the target.

A SCSI command that fails with ILLEGAL_REQUEST sense and Additional
sense 0x20, 0x21, 0x24 or 0x26 represents a permanent TARGET_ERROR.

Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 89730393

drivers/scsi/scsi_error.c

+8 −0
Original line number Diff line number Diff line
@@ -366,6 +366,14 @@ static int scsi_check_sense(struct scsi_cmnd *scmd) 
			return TARGET_ERROR;



	case ILLEGAL_REQUEST:

		if (sshdr.asc == 0x20 || /* Invalid command operation code */

		    sshdr.asc == 0x21 || /* Logical block address out of range */

		    sshdr.asc == 0x24 || /* Invalid field in cdb */

		    sshdr.asc == 0x26) { /* Parameter value invalid */

			return TARGET_ERROR;

		}

		return SUCCESS;



	default:

		return SUCCESS;

	}