Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 47052577 authored by Alexey Khoroshilov's avatar Alexey Khoroshilov Committed by Greg Kroah-Hartman
Browse files

staging: gdm7240: fix memory leak on failure path 



init_usb() may fail after some of mux_rxes already allocated.
So we need to release them on the failure path.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a4d8c83c

drivers/staging/gdm724x/gdm_mux.c

+2 −2
Original line number Diff line number Diff line
@@ -541,7 +541,7 @@ static int gdm_mux_probe(struct usb_interface *intf, const struct usb_device_id 


	ret = init_usb(mux_dev);

	if (ret)

		goto err_free_tty;

		goto err_free_usb;



	tty_dev->priv_dev = (void *)mux_dev;

	tty_dev->send_func = gdm_mux_send;
@@ -565,8 +565,8 @@ static int gdm_mux_probe(struct usb_interface *intf, const struct usb_device_id 


err_unregister_tty:

	unregister_lte_tty_device(tty_dev);

err_free_usb:

	release_usb(mux_dev);

err_free_tty:

	kfree(tty_dev);

err_free_mux:

	kfree(mux_dev);