Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 464c1147 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

ACPI: Print diagnostic messages if device links cannot be created 



Although the device links created by acpi_bind_one() are not
essential from the kernel functionality point of view, user space
may be confused when they are missing, so print diagnostic messages
to the kernel log if they can't be created.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: default avatarToshi Kani <toshi.kani@hp.com>
parent 3342c753

drivers/acpi/glue.c

+7 −0
Original line number Diff line number Diff line
@@ -252,8 +252,15 @@ int acpi_bind_one(struct device *dev, acpi_handle handle) 
	acpi_physnode_link_name(physical_node_name, node_id);

	retval = sysfs_create_link(&acpi_dev->dev.kobj, &dev->kobj,

				   physical_node_name);

	if (retval)

		dev_err(&acpi_dev->dev, "Failed to create link %s (%d)\n",

			physical_node_name, retval);



	retval = sysfs_create_link(&dev->kobj, &acpi_dev->dev.kobj,

				   "firmware_node");

	if (retval)

		dev_err(dev, "Failed to create link firmware_node (%d)\n",

			retval);



	mutex_unlock(&acpi_dev->physical_node_lock);