Commit 45a521cb authored Sep 01, 2017 by Steven Rostedt (VMware) Committed by Greg Kroah-Hartman Sep 27, 2017

ftrace: Fix selftest goto location on error

commit 46320a6acc4fb58f04bcf78c4c942cc43b20f986 upstream.

In the second iteration of trace_selftest_ops(), the error goto label is
wrong in the case where trace_selftest_test_global_cnt is off. In the
case of error, it leaks the dynamic ops that was allocated.

Fixes: 95950c2e ("ftrace: Add self-tests for multiple function trace users")
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 78d88643

kernel/trace/trace_selftest.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -272,7 +272,7 @@ static int trace_selftest_ops(struct trace_array *tr, int cnt)
		goto out_free;
		if (cnt > 1) {
		if (trace_selftest_test_global_cnt == 0)
		goto out;
		goto out_free;
		}
		if (trace_selftest_test_dyn_cnt == 0)
		goto out_free;