Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 457c2510 authored by Pavel Emelyanov's avatar Pavel Emelyanov Committed by Linus Torvalds
Browse files

Remove unused variables from fs/proc/base.c 



When removing the explicit task_struct->pid usage I found that
proc_readfd_common() and proc_pident_readdir() get this field, but do not
use it at all.  So this cleanup is a cheap help with the task_struct->pid
isolation.

Signed-off-by: default avatarPavel Emelyanov <xemul@openvz.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 19c5870c

fs/proc/base.c

+1 −4
Original line number Diff line number Diff line
@@ -1519,7 +1519,7 @@ static int proc_readfd_common(struct file * filp, void * dirent, 
	struct dentry *dentry = filp->f_path.dentry;

	struct inode *inode = dentry->d_inode;

	struct task_struct *p = get_proc_task(inode);

	unsigned int fd, tid, ino;

	unsigned int fd, ino;

	int retval;

	struct files_struct * files;

	struct fdtable *fdt;
@@ -1528,7 +1528,6 @@ static int proc_readfd_common(struct file * filp, void * dirent, 
	if (!p)

		goto out_no_task;

	retval = 0;

	tid = p->pid;



	fd = filp->f_pos;

	switch (fd) {
@@ -1763,7 +1762,6 @@ static int proc_pident_readdir(struct file *filp, 
		const struct pid_entry *ents, unsigned int nents)

{

	int i;

	int pid;

	struct dentry *dentry = filp->f_path.dentry;

	struct inode *inode = dentry->d_inode;

	struct task_struct *task = get_proc_task(inode);
@@ -1776,7 +1774,6 @@ static int proc_pident_readdir(struct file *filp, 
		goto out_no_task;



	ret = 0;

	pid = task->pid;

	i = filp->f_pos;

	switch (i) {

	case 0: