Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 44c54350 authored by Omar Ramirez Luna's avatar Omar Ramirez Luna Committed by Greg Kroah-Hartman
Browse files

staging: tidspbridge: fix incorrect free to drv_datap 



This structure is still used after it has been freed, since it
is being allocated in probe, calls to free it have been moved to
module's remove routine.

This should fix the follwoing messages when attempting to remove the
module:
 drv_get_first_dev_extension: Failed to retrieve the object handle
 drv_get_first_dev_extension: Failed to retrieve the object handle
 drv_destroy: Failed to store DRV object
 mgr_destroy: Failed to store MGR object

Signed-off-by: default avatarOmar Ramirez Luna <omar.ramirez@ti.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5a63177a

drivers/staging/tidspbridge/core/tiomap3430.c

+0 −2
Original line number Diff line number Diff line
@@ -1046,8 +1046,6 @@ static int bridge_dev_destroy(struct bridge_dev_context *dev_ctxt) 


	/* Free the driver's device context: */

	kfree(drv_datap->base_img);

	kfree(drv_datap);

	dev_set_drvdata(bridge, NULL);

	kfree((void *)dev_ctxt);

	return status;

}

drivers/staging/tidspbridge/rmgr/drv_interface.c

+3 −0
Original line number Diff line number Diff line
@@ -410,6 +410,9 @@ static int __devexit omap34_xx_bridge_remove(struct platform_device *pdev) 
		DBC_ASSERT(ret == true);

	}



	kfree(drv_datap);

	dev_set_drvdata(bridge, NULL);



func_cont:

	mem_ext_phys_pool_release();