Commit 44c05b35 authored Apr 05, 2018 by Eric Dumazet Committed by Greg Kroah-Hartman Apr 13, 2018

ip6_tunnel: better validate user provided tunnel names




[ Upstream commit db7a65e3ab78e5b1c4b17c0870ebee35a4ee3257 ]

Use valid_name() to make sure user does not provide illegal
device name.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent ff54063c

net/ipv6/ip6_tunnel.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -307,10 +307,13 @@ static struct ip6_tnl ip6_tnl_create(struct net net, struct __ip6_tnl_parm *p)
		char name[IFNAMSIZ];
		int err;

		if (p->name[0])
		if (p->name[0]) {
		if (!dev_valid_name(p->name))
		goto failed;
		strlcpy(name, p->name, IFNAMSIZ);
		else
		} else {
		sprintf(name, "ip6tnl%%d");
		}

		dev = alloc_netdev(sizeof(*t), name, NET_NAME_UNKNOWN,
		ip6_tnl_dev_setup);