Commit 44a6995b authored Dec 30, 2007 by Tom Tucker Committed by J. Bruce Fields Feb 01, 2008

svc: Remove unnecessary call to svc_sock_enqueue



The svc_tcp_accept function calls svc_sock_enqueue after setting the
SK_CONN bit. This doesn't actually do anything because the SK_BUSY bit
is still set. The call is unnecessary anyway because the generic code in
svc_recv calls svc_sock_received after calling the accept function.

Signed-off-by: Tom Tucker <tom@opengridcomputing.com>
Acked-by: Neil Brown <neilb@suse.de>
Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
Reviewed-by: Greg Banks <gnb@sgi.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>

parent 38a417cc

net/sunrpc/svcsock.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1064,7 +1064,6 @@ static struct svc_xprt svc_tcp_accept(struct svc_xprt xprt)
		}

		set_bit(SK_CONN, &svsk->sk_flags);
		svc_sock_enqueue(svsk);

		err = kernel_getpeername(newsock, sin, &slen);
		if (err < 0) {