Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 448011e2 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Dave Chinner
Browse files

xfs: tone down writepage/releasepage WARN_ONs 



I recently ran into the issue fixed by

  "xfs: kill buffers over failed write ranges properly"

which spams the log with lots of backtraces.  Make debugging any
issues like that easier by using WARN_ON_ONCE in the writeback code.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
parent 72208ee0

fs/xfs/xfs_aops.c

+3 −3
Original line number Diff line number Diff line
@@ -975,7 +975,7 @@ xfs_vm_writepage( 
	 * Given that we do not allow direct reclaim to call us, we should

	 * never be called while in a filesystem transaction.

	 */

	if (WARN_ON(current->flags & PF_FSTRANS))

	if (WARN_ON_ONCE(current->flags & PF_FSTRANS))

		goto redirty;



	/* Is this page beyond the end of the file? */
@@ -1188,9 +1188,9 @@ xfs_vm_releasepage( 


	xfs_count_page_state(page, &delalloc, &unwritten);



	if (WARN_ON(delalloc))

	if (WARN_ON_ONCE(delalloc))

		return 0;

	if (WARN_ON(unwritten))

	if (WARN_ON_ONCE(unwritten))

		return 0;



	return try_to_free_buffers(page);